Create PR Follow

BEFORE CREATION OF THE PULL REQUEST (PR) on GitHub , next requirements MUST BE MET:

feature ABSOLUTELY needs to be tested locally and needs to work locally
migrations and seeders need to run flawlessly locally
The developer also needs to check if migration is also and working in some of the DB IDE’s (DbBeaver, Mysql Workbench), for i.e. if FK or index needs to be added we need to visually confirm it’s really there in DB
all UNIT TESTS need to pass FULLY locally and on GitHub Actions
PR’s should be created when they are prone to be released or for review
PR’s can not stay longer then few days, otherwise they will be closed
PR’s need to be tested locally, by the Frontend Team and demo before making the release. If you have a PR that was reviewed and you have to do changes then when you do all of the above criteria do not forget to re-request the reviewer, so that way the reviewer knows it’s ready for inspection

Last updated 2 years ago